This repository was archived by the owner on Dec 19, 2019. It is now read-only.
Fixed return value for getGraphQlClient in API-functional tests#127
Merged
magento-engcom-team merged 4 commits into2.3-developfrom Aug 16, 2018
Merged
Fixed return value for getGraphQlClient in API-functional tests#127magento-engcom-team merged 4 commits into2.3-developfrom
magento-engcom-team merged 4 commits into2.3-developfrom
Conversation
naydav
reviewed
Jul 20, 2018
| } else { | ||
| $this->graphQlClient; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Looks like logic should be
if ($this->graphQlClient === null) {
$this->graphQlClient = Bootstrap::getObjectManager()->get(\Magento\TestFramework\TestCase\GraphQl\Client::class);
}
return $this->graphQlClient;
Contributor
Author
|
Hi @naydav. Thank you for your review. I've added the mentioned changes |
added 2 commits
August 13, 2018 16:19
…l tests -- Fix static tests
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 16, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
May 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
\Magento\TestFramework\TestCase\GraphQlAbstract::getGraphQlClientis supposed to return\Magento\TestFramework\TestCase\GraphQl\Client. However, ifgraphQlClientwas initialized previously, the method returns nothing.The fix adjusts the return behavior. So
getGraphQlClientalways returns correct value.Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A